1 | |
|
2 | |
|
3 | |
|
4 | |
|
5 | |
|
6 | |
|
7 | |
|
8 | |
|
9 | |
|
10 | |
|
11 | |
|
12 | |
|
13 | |
|
14 | |
|
15 | |
|
16 | |
|
17 | |
|
18 | |
|
19 | |
|
20 | |
|
21 | |
|
22 | |
|
23 | |
|
24 | |
|
25 | |
|
26 | |
|
27 | |
|
28 | |
|
29 | |
|
30 | |
|
31 | |
|
32 | |
|
33 | |
package com.jeantessier.dependency; |
34 | |
|
35 | |
import junit.framework.TestCase; |
36 | |
|
37 | |
import java.util.Arrays; |
38 | |
import java.util.Collection; |
39 | |
import java.util.Map; |
40 | |
|
41 | 11 | public class TestLCOM4Gatherer extends TestCase { |
42 | |
private NodeFactory factory; |
43 | |
|
44 | |
private LCOM4Gatherer sut; |
45 | |
|
46 | |
protected void setUp() throws Exception { |
47 | 11 | super.setUp(); |
48 | |
|
49 | 11 | factory = new NodeFactory(); |
50 | |
|
51 | 11 | sut = new LCOM4Gatherer(); |
52 | 11 | } |
53 | |
|
54 | |
public void testNothing() { |
55 | 1 | sut.traverseNodes(factory.getPackages().values()); |
56 | |
|
57 | 1 | Map<ClassNode, Collection<Collection<FeatureNode>>> actualResults = sut.getResults(); |
58 | 1 | assertTrue(actualResults.isEmpty()); |
59 | 1 | } |
60 | |
|
61 | |
public void testEmptyPackage() { |
62 | 1 | factory.createPackage("", true); |
63 | |
|
64 | 1 | sut.traverseNodes(factory.getPackages().values()); |
65 | |
|
66 | 1 | Map<ClassNode, Collection<Collection<FeatureNode>>> actualResults = sut.getResults(); |
67 | 1 | assertTrue(actualResults.isEmpty()); |
68 | 1 | } |
69 | |
|
70 | |
public void testEmptyClass() { |
71 | 1 | ClassNode classNode = factory.createClass("Empty", true); |
72 | |
|
73 | 1 | sut.traverseNodes(factory.getPackages().values()); |
74 | |
|
75 | 1 | Map<ClassNode, Collection<Collection<FeatureNode>>> actualResults = sut.getResults(); |
76 | 1 | assertEquals("nb results", 1, actualResults.keySet().size()); |
77 | 1 | assertTrue(classNode.getName() + " is missing from " + actualResults, actualResults.containsKey(classNode)); |
78 | |
|
79 | 1 | Collection<Collection<FeatureNode>> components = actualResults.get(classNode); |
80 | 1 | assertEquals("LCOM4 of empty class", 0, components.size()); |
81 | 1 | } |
82 | |
|
83 | |
|
84 | |
|
85 | |
|
86 | |
|
87 | |
public void testOneFeature() { |
88 | 1 | FeatureNode featureNode = factory.createFeature("One.one", true); |
89 | |
|
90 | 1 | sut.traverseNodes(factory.getPackages().values()); |
91 | |
|
92 | 1 | Map<ClassNode, Collection<Collection<FeatureNode>>> actualResults = sut.getResults(); |
93 | 1 | assertEquals("nb results", 1, actualResults.keySet().size()); |
94 | 1 | assertTrue(featureNode.getClassNode().getName() + " is missing from " + actualResults, actualResults.containsKey(featureNode.getClassNode())); |
95 | |
|
96 | 1 | Collection<Collection<FeatureNode>> components = actualResults.get(featureNode.getClassNode()); |
97 | 1 | assertEquals("LCOM4 of class w/ one feature", 1, components.size()); |
98 | |
|
99 | 1 | Collection<FeatureNode> component = components.iterator().next(); |
100 | 1 | assertEquals("Size of first component", 1, component.size()); |
101 | 1 | assertTrue(component.contains(featureNode)); |
102 | 1 | } |
103 | |
|
104 | |
|
105 | |
|
106 | |
|
107 | |
|
108 | |
public void testTwoDisjointFeatures() { |
109 | 1 | FeatureNode featureNode1 = factory.createFeature("Two.one", true); |
110 | 1 | FeatureNode featureNode2 = factory.createFeature("Two.two", true); |
111 | |
|
112 | 1 | sut.traverseNodes(factory.getPackages().values()); |
113 | |
|
114 | 1 | Map<ClassNode, Collection<Collection<FeatureNode>>> actualResults = sut.getResults(); |
115 | 1 | assertEquals("nb results", 1, actualResults.keySet().size()); |
116 | 1 | assertTrue(featureNode1.getClassNode().getName() + " is missing from " + actualResults, actualResults.containsKey(featureNode1.getClassNode())); |
117 | |
|
118 | 1 | Collection<Collection<FeatureNode>> components = actualResults.get(featureNode1.getClassNode()); |
119 | 1 | assertEquals("LCOM4 of class w/ two disjoint features", 2, components.size()); |
120 | |
|
121 | 1 | assertAtLeastOneComponentEquals(components, featureNode1); |
122 | 1 | assertAtLeastOneComponentEquals(components, featureNode2); |
123 | 1 | } |
124 | |
|
125 | |
|
126 | |
|
127 | |
|
128 | |
|
129 | |
public void testTwoConnectedFeatures() { |
130 | 1 | FeatureNode featureNode1 = factory.createFeature("Two.one", true); |
131 | 1 | FeatureNode featureNode2 = factory.createFeature("Two.two", true); |
132 | |
|
133 | 1 | featureNode1.addDependency(featureNode2); |
134 | |
|
135 | 1 | sut.traverseNodes(factory.getPackages().values()); |
136 | |
|
137 | 1 | Map<ClassNode, Collection<Collection<FeatureNode>>> actualResults = sut.getResults(); |
138 | 1 | assertEquals("nb results", 1, actualResults.keySet().size()); |
139 | 1 | assertTrue(featureNode1.getClassNode().getName() + " is missing from " + actualResults, actualResults.containsKey(featureNode1.getClassNode())); |
140 | |
|
141 | 1 | Collection<Collection<FeatureNode>> components = actualResults.get(featureNode1.getClassNode()); |
142 | 1 | assertEquals("LCOM4 of class w/ two connected features", 1, components.size()); |
143 | |
|
144 | 1 | assertAtLeastOneComponentEquals(components, featureNode1, featureNode2); |
145 | 1 | } |
146 | |
|
147 | |
|
148 | |
|
149 | |
|
150 | |
|
151 | |
public void testThreeConnectedFeatures() { |
152 | 1 | FeatureNode featureNode1 = factory.createFeature("Three.one", true); |
153 | 1 | FeatureNode featureNode2 = factory.createFeature("Three.two", true); |
154 | 1 | FeatureNode featureNode3 = factory.createFeature("Three.three", true); |
155 | |
|
156 | 1 | featureNode1.addDependency(featureNode2); |
157 | 1 | featureNode2.addDependency(featureNode3); |
158 | |
|
159 | 1 | sut.traverseNodes(factory.getPackages().values()); |
160 | |
|
161 | 1 | Map<ClassNode, Collection<Collection<FeatureNode>>> actualResults = sut.getResults(); |
162 | 1 | assertEquals("nb results", 1, actualResults.keySet().size()); |
163 | 1 | assertTrue(featureNode1.getClassNode().getName() + " is missing from " + actualResults, actualResults.containsKey(featureNode1.getClassNode())); |
164 | |
|
165 | 1 | Collection<Collection<FeatureNode>> components = actualResults.get(featureNode1.getClassNode()); |
166 | 1 | assertEquals("LCOM4 of class w/ three connected features", 1, components.size()); |
167 | |
|
168 | 1 | assertAtLeastOneComponentEquals(components, featureNode1, featureNode2, featureNode3); |
169 | 1 | } |
170 | |
|
171 | |
|
172 | |
|
173 | |
|
174 | |
|
175 | |
|
176 | |
public void testTwoConnectedFeaturesInSeparateClasses() { |
177 | 1 | FeatureNode featureNode1 = factory.createFeature("One.one", true); |
178 | 1 | FeatureNode featureNode2 = factory.createFeature("Two.two", true); |
179 | |
|
180 | 1 | featureNode1.addDependency(featureNode2); |
181 | |
|
182 | 1 | sut.traverseNodes(factory.getPackages().values()); |
183 | |
|
184 | 1 | Map<ClassNode, Collection<Collection<FeatureNode>>> actualResults = sut.getResults(); |
185 | 1 | assertEquals("nb results", 2, actualResults.keySet().size()); |
186 | 1 | assertTrue(featureNode1.getClassNode().getName() + " is missing from " + actualResults, actualResults.containsKey(featureNode1.getClassNode())); |
187 | |
|
188 | 1 | Collection<Collection<FeatureNode>> components = actualResults.get(featureNode1.getClassNode()); |
189 | 1 | assertEquals("LCOM4 of class w/ feature connected to other class", 1, components.size()); |
190 | |
|
191 | 1 | assertAtLeastOneComponentEquals(components, featureNode1); |
192 | 1 | } |
193 | |
|
194 | |
|
195 | |
|
196 | |
|
197 | |
|
198 | |
|
199 | |
|
200 | |
public void testTwoIndirectlyConnectedFeatures() { |
201 | 1 | FeatureNode featureNode1 = factory.createFeature("One.one", true); |
202 | 1 | FeatureNode featureNode2 = factory.createFeature("Two.two", true); |
203 | 1 | FeatureNode featureNode3 = factory.createFeature("One.two", true); |
204 | |
|
205 | 1 | featureNode1.addDependency(featureNode2); |
206 | 1 | featureNode2.addDependency(featureNode3); |
207 | |
|
208 | 1 | sut.traverseNodes(factory.getPackages().values()); |
209 | |
|
210 | 1 | Map<ClassNode, Collection<Collection<FeatureNode>>> actualResults = sut.getResults(); |
211 | 1 | assertEquals("nb results", 2, actualResults.keySet().size()); |
212 | 1 | assertTrue(featureNode1.getClassNode().getName() + " is missing from " + actualResults, actualResults.containsKey(featureNode1.getClassNode())); |
213 | |
|
214 | 1 | Collection<Collection<FeatureNode>> components = actualResults.get(featureNode1.getClassNode()); |
215 | 1 | assertEquals("LCOM4 of class w/ features connected through other class", 2, components.size()); |
216 | |
|
217 | 1 | assertAtLeastOneComponentEquals(components, featureNode1); |
218 | 1 | assertAtLeastOneComponentEquals(components, featureNode3); |
219 | 1 | } |
220 | |
|
221 | |
public void testIgnoreConstructor() { |
222 | 1 | ClassNode classNode = factory.createClass("One", true); |
223 | 1 | factory.createFeature("One.One()", true); |
224 | |
|
225 | 1 | sut.traverseNodes(factory.getPackages().values()); |
226 | |
|
227 | 1 | Map<ClassNode, Collection<Collection<FeatureNode>>> actualResults = sut.getResults(); |
228 | 1 | assertEquals("nb results", 1, actualResults.keySet().size()); |
229 | 1 | assertTrue(classNode.getName() + " is missing from " + actualResults, actualResults.containsKey(classNode)); |
230 | |
|
231 | 1 | Collection<Collection<FeatureNode>> components = actualResults.get(classNode); |
232 | 1 | assertEquals("LCOM4 of class w/ only constructors", 0, components.size()); |
233 | 1 | } |
234 | |
|
235 | |
public void testIgnoreConstructor_WithinGraph() { |
236 | 1 | ClassNode classNode = factory.createClass("Three", true); |
237 | 1 | FeatureNode constructorNode = factory.createFeature("Three.Three()", true); |
238 | 1 | FeatureNode featureNode1 = factory.createFeature("Three.one", true); |
239 | 1 | FeatureNode featureNode2 = factory.createFeature("Three.two", true); |
240 | |
|
241 | 1 | constructorNode.addDependency(featureNode1); |
242 | 1 | constructorNode.addDependency(featureNode2); |
243 | |
|
244 | 1 | sut.traverseNodes(factory.getPackages().values()); |
245 | |
|
246 | 1 | Map<ClassNode, Collection<Collection<FeatureNode>>> actualResults = sut.getResults(); |
247 | 1 | assertEquals("nb results", 1, actualResults.keySet().size()); |
248 | 1 | assertTrue(classNode.getName() + " is missing from " + actualResults, actualResults.containsKey(classNode)); |
249 | |
|
250 | 1 | Collection<Collection<FeatureNode>> components = actualResults.get(classNode); |
251 | 1 | assertEquals("LCOM4 of class w/ two features connected through the constructor " + components, 2, components.size()); |
252 | |
|
253 | 1 | assertAtLeastOneComponentEquals(components, featureNode1); |
254 | 1 | assertAtLeastOneComponentEquals(components, featureNode2); |
255 | 1 | } |
256 | |
|
257 | |
private void assertAtLeastOneComponentEquals(Collection<Collection<FeatureNode>> components, FeatureNode ... expectedNodes) { |
258 | 9 | boolean found = false; |
259 | |
|
260 | 9 | for (Collection<FeatureNode> component : components) { |
261 | 15 | found = found || checkComponentEquals(component, expectedNodes); |
262 | |
} |
263 | |
|
264 | 9 | assertTrue(Arrays.asList(expectedNodes) + " not in " + components, found); |
265 | 9 | } |
266 | |
|
267 | |
private boolean checkComponentEquals(Collection<FeatureNode> component, FeatureNode ... expectedNodes) { |
268 | 12 | boolean result = expectedNodes.length == component.size(); |
269 | |
|
270 | 27 | for (FeatureNode expectedNode : expectedNodes) { |
271 | 15 | result = result && component.contains(expectedNode); |
272 | |
} |
273 | |
|
274 | 12 | return result; |
275 | |
} |
276 | |
} |